[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] monitor: Cleanup mon->outbuf on write error
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH] monitor: Cleanup mon->outbuf on write error |
Date: |
Wed, 29 Jan 2014 09:12:44 -0500 |
On Wed, 29 Jan 2014 12:46:04 +0200
Stratos Psomadakis <address@hidden> wrote:
> On 01/27/2014 12:30 PM, Stratos Psomadakis wrote:
> > In case monitor_flush() fails to write the contents of mon->outbuf to
> > the output device, mon->outbuf is not cleaned up properly. Check the
> > return code of the qemu_chr_fe_write() function and cleanup the outbuf
> > if it fails.
> >
> > References:
> > http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg02890.html
> >
> > Signed-off-by: Stratos Psomadakis <address@hidden>
> > Signed-off-by: Dimitris Aragiorgis <address@hidden>
> > ---
> > monitor.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/monitor.c b/monitor.c
> > index 80456fb..cba56bc 100644
> > --- a/monitor.c
> > +++ b/monitor.c
> > @@ -288,8 +288,8 @@ void monitor_flush(Monitor *mon)
> >
> > if (len && !mon->mux_out) {
> > rc = qemu_chr_fe_write(mon->chr, (const uint8_t *) buf, len);
> > - if (rc == len) {
> > - /* all flushed */
> > + if ((rc < 0 && errno != EAGAIN) || (rc == len)) {
> > + /* all flushed or error */
> > QDECREF(mon->outbuf);
> > mon->outbuf = qstring_new();
> > return;
>
> Forgot to cc the maintainer.
I included it in my pull request:
http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg03859.html
But it seems that I forgot to reply to the patch too.
- Re: [Qemu-devel] Possible bug in monitor code, Fam Zheng, 2014/01/23
- Re: [Qemu-devel] Possible bug in monitor code, Luiz Capitulino, 2014/01/23
- Re: [Qemu-devel] Possible bug in monitor code, Luiz Capitulino, 2014/01/23
- Re: [Qemu-devel] Possible bug in monitor code, Stratos Psomadakis, 2014/01/23
- Re: [Qemu-devel] Possible bug in monitor code, Luiz Capitulino, 2014/01/23
- Re: [Qemu-devel] Possible bug in monitor code, Stratos Psomadakis, 2014/01/24
- Re: [Qemu-devel] Possible bug in monitor code, Luiz Capitulino, 2014/01/24
- Re: [Qemu-devel] Possible bug in monitor code, Apollon Oikonomopoulos, 2014/01/24