[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/42] input: qapi: add unmapped key
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 07/42] input: qapi: add unmapped key |
Date: |
Thu, 30 Jan 2014 17:28:07 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 01/28/2014 02:57 AM, Gerd Hoffmann wrote:
> Simplifies building something -> QkeyCode mapping tables.
> Uninitialized entries can easily identified then.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
> qapi-schema.json | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 646d64f..6af22f6 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3429,9 +3429,12 @@
> # This is used by the send-key command.
> #
> # Since: 1.3.0
> +#
> +# 'unmapped' since 2.0
Typically written:
# @unmapped: no key assignment (since 2.0)
#
# Since: 1.3.0
But then again, I don't know that we have very good precedent for
extending enums and documenting just the new values, so I can live with
what you did.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 31/42] input: trace events, (continued)
- [Qemu-devel] [PATCH 31/42] input: trace events, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 33/42] input-legacy: remove kbd_mouse_has_absolute, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 20/42] input: mouse: add graphic_rotate support, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 34/42] input-legacy: remove kbd_mouse_is_absolute, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 40/42] input: move qmp_query_mice to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 36/42] input: move mouse mode notifier to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 32/42] input-legacy: remove kbd_put_keycode, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 37/42] input: add input_mouse_mode tracepoint, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 41/42] input: move do_mouse_set to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 07/42] input: qapi: add unmapped key, Gerd Hoffmann, 2014/01/28
- Re: [Qemu-devel] [PATCH 07/42] input: qapi: add unmapped key,
Eric Blake <=
- [Qemu-devel] [PATCH 29/42] input: keyboard: switch cocoa ui to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 19/42] input: mouse: add helpers functions to core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 28/42] input: mouse: switch monitor to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 42/42] input: remove index_from_keycode (no users), Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 30/42] input: mouse: switch cocoa ui to new core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 10/42] input: keyboard: add helper functions to core, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 02/42] sdl2: baum build fix, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 38/42] sdl2: simplify keymap handling, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 39/42] sdl2: codestyle fixups, Gerd Hoffmann, 2014/01/28
- [Qemu-devel] [PATCH 08/42] input: qapi: add pause key, Gerd Hoffmann, 2014/01/28