Re: [Qemu-devel] [PATCH 08/10] block: Reuse bs->options setting from bdrv_open()

[Max Reitz]

On 29.01.2014 14:45, Kevin Wolf wrote:
> Am 26.01.2014 um 20:02 hat Max Reitz geschrieben:
> > Setting bs->options in bdrv_file_open() is not necessary if it is
> > already done in bdrv_open().
> >
> > Signed-off-by: Max Reitz <address@hidden>
> Perhaps squash this into patch 7? Because now the reference is created
> by bdrv_open() instead of bdrv_file_open().

Yes, why not.

> Also my suggestion in a reply to a patch earlier in this series (keeping
> all option-related code at one place), probably means that it all needs
> to be done together (or immediately after) handling the NULL options
> case.

I'll have a look.


Thank you for reviewing.

Max