[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/10] qapi: Drop nonsensical header guard in ge
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 08/10] qapi: Drop nonsensical header guard in generated qapi-visit.c |
Date: |
Thu, 06 Feb 2014 19:52:54 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 02/06/2014 07:29 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> scripts/qapi-visit.py | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
>
> diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
> index 65f1a54..ff4239c 100644
> --- a/scripts/qapi-visit.py
> +++ b/scripts/qapi-visit.py
> @@ -494,10 +494,8 @@ fdecl.write(guardend("QAPI_VISIT_BUILTIN_VISITOR_DECL"))
> # have the functions defined, so we use -b option to provide control
> # over these cases
> if do_builtins:
> - fdef.write(guardstart("QAPI_VISIT_BUILTIN_VISITOR_DEF"))
> for typename in builtin_types:
> fdef.write(generate_visit_list(typename, None))
> - fdef.write(guardend("QAPI_VISIT_BUILTIN_VISITOR_DEF"))
>
> for expr in exprs:
> if expr.has_key('type'):
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors, (continued)
- Re: [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors, Paolo Bonzini, 2014/02/07
- Re: [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors, Markus Armbruster, 2014/02/07
- Re: [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors, Paolo Bonzini, 2014/02/07
- Re: [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors, Markus Armbruster, 2014/02/10
- Re: [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors, Paolo Bonzini, 2014/02/11
- Re: [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors, Markus Armbruster, 2014/02/11
[Qemu-devel] [PATCH 02/10] tests/qapi-schema: Cover optional command arguments, Markus Armbruster, 2014/02/06
[Qemu-devel] [PATCH 08/10] qapi: Drop nonsensical header guard in generated qapi-visit.c, Markus Armbruster, 2014/02/06
- Re: [Qemu-devel] [PATCH 08/10] qapi: Drop nonsensical header guard in generated qapi-visit.c,
Eric Blake <=
[Qemu-devel] [PATCH 09/10] qapi: Drop unused code in qapi-commands.py, Markus Armbruster, 2014/02/06
[Qemu-devel] [PATCH 04/10] tests/qapi-schema: Cover anonymous union types, Markus Armbruster, 2014/02/06