Re: [Qemu-devel] [PATCH qom-next 1/5] tests: Add e1000 qtest

[Stefan Hajnoczi]

On Fri, Feb 07, 2014 at 07:06:58PM +0100, Andreas Färber wrote:
> Am 07.02.2014 16:48, schrieb Stefan Hajnoczi:
> > On Wed, Feb 05, 2014 at 06:01:13PM +0100, Andreas Färber wrote:
> >> +#include "libqtest.h"
> >> +
> >> +#include <glib.h>
> >> +#include <string.h>
> >> +#include "qemu/osdep.h"
> > 
> > Please put <system.h> includes before "user.h" includes.  That way we
> > can be sure our macros don't mess up system headers.
> 
> You are right in this case, but to my defense I copied this from another
> file. ;) You'll find the "libqtest.h"-first pattern in:
> 
> endianness-test.c
> fw_cfg-test.c
> i440fx-test.c
> m48t59-test.c
> qom-test.c
> rtc-test.c
> tmp105-test.c
> 
> To make it clearer which example to copy from, feel free to submit a
> patch cleaning those up.

Okay, I will.  Thanks!

Stefan