Re: [Qemu-devel] [PATCH 11/11] i2c: Drop FROM_I2C_SLAVE() macro

[Peter Crosthwaite]

On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber <address@hidden> wrote:
> Use type-specific QOM cast macros instead.
>

Should be past tense - "We now use type-specific ...". The imperative
form of "use" suggests you are making the change in this patch but you
have already done it.

> Signed-off-by: Andreas Färber <address@hidden>

Reviewed-by: Peter Crosthwaite <address@hidden>

> ---
>  include/hw/i2c/i2c.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/include/hw/i2c/i2c.h b/include/hw/i2c/i2c.h
> index 9df987b..4986ebc 100644
> --- a/include/hw/i2c/i2c.h
> +++ b/include/hw/i2c/i2c.h
> @@ -59,8 +59,6 @@ void i2c_nack(I2CBus *bus);
>  int i2c_send(I2CBus *bus, uint8_t data);
>  int i2c_recv(I2CBus *bus);
>
> -#define FROM_I2C_SLAVE(type, dev) DO_UPCAST(type, i2c, dev)
> -
>  DeviceState *i2c_create_slave(I2CBus *bus, const char *name, uint8_t addr);
>
>  /* wm8750.c */
> --
> 1.8.4.5
>
>