Re: [Qemu-devel] [PATCH] target-ppc: fix warn_unused_result build break with in-kernel HTAB support

[Alexander Graf]

On 13.02.2014, at 04:00, Aneesh Kumar K.V <address@hidden> wrote:

> Greg Kurz <address@hidden> writes:
> 
>> The 7029677e4 commit introduced the following build break:
>> 
>> target-ppc/kvm.c: In function ‘kvmppc_hash64_write_pte’:
>> target-ppc/kvm.c:2017:10: error: ignoring return value of ‘write’, declared
>> with attribute warn_unused_result [-Werror=unused-result]
>>     write(htab_fd, &hpte_buf, sizeof(hpte_buf));
>>          ^
>> 
>> Even though nothing is done for the moment if kvm_htab_write() fails, we
>> obviously need to be explicit. Let's add an *empty* return path to please
>> gcc.
>> 
> 
> Reviewed-by: Aneesh Kumar K.V <address@hidden>

Thanks, applied to ppc-next.


Alex