|
From: | Max Reitz |
Subject: | Re: [Qemu-devel] [PATCH V17 00/12] quorum block filter |
Date: | Sat, 15 Feb 2014 03:04:03 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 15.02.2014 02:15, Max Reitz wrote:
On 12.02.2014 23:06, Benoît Canet wrote:I post this for review in prevision of 2.0 feature freeze. Even if the series look correct please wait before merging because:The QMP events in the "Add quorum mechanism" definitively needs to be reviewedby Eric as they where changed.I did not found any bugs while testing this version but I am willing to test thecode further before it's applied even it's reviewed by. Best regards BenoîtJust one thing in general: You left my reviewed-by note on many patches of the series although basically every single patch has changed (some more, some less). This makes it harder for me to review (okay, not really; I can (and should) still compare with the old versions for the actual changes, but if I fail to do so...) and can cause some patches to be merged because "I reviewed it" (although I actually didn't) - probably not in this case since it's hard here to pick single patches to merge, but well...Max
The reviewed-by for all the patches I didn't reply to (7, 8, 10, 12) is okay and I'm hereby renewing it.
Max
[Prev in Thread] | Current Thread | [Next in Thread] |