Re: [Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include "cpu.h"' from include/qemu-common.h

[Paolo Bonzini]

Il 04/03/2014 13:26, Xuebing wang ha scritto:
> > >  #ifdef NEED_CPU_H
> > > +#include "cpu.h" /* target-xxx/cpu.h, required for target_ulong */
> > >
> > >  void kvm_setup_guest_memory(void *start, size_t size);
> > >  void kvm_flush_coalesced_mmio_buffer(void);
> >
> > Perhaps move debugging-related definitions to a new file
> > sysemu/kvm-debug.h and include it only from gdbstub.c, kvm-all.c,
> > kvm-stub.c, target-*/kvm.c.
>
> Thanks for suggestion. This patch is strictly confined to "NEED_CPU_H"
> and making qemu build. :-)

Making QEMU build is not a good idea if it complicates things.  Adding 
dependencies to a file complicates things.  What you're doing here is 
taking dependencies out of one central file (qemu-common.h) and adding 
it to a dozen peripheral files.  This complicates things.

Removing "#ifdef NEED_CPU_H" can be a good idea, but it has to make 
things simpler, otherwise it is not a good idea anymore.

Paolo