[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC for-2.0] bswap: Fix build on FreeBSD 10.0
|
From: |
Ed Maste |
|
Subject: |
Re: [Qemu-devel] [RFC for-2.0] bswap: Fix build on FreeBSD 10.0 |
|
Date: |
Wed, 2 Apr 2014 16:57:06 -0400 |
On 2 April 2014 14:52, Richard Henderson <address@hidden> wrote:
> On 04/02/2014 07:06 AM, Andreas Färber wrote:
>> FreeBSD 10.0-RELEASE has bswap16() etc. macros defined in sys/endian.h,
>> which leads to a conflict with our static inline definitions.
>>
>> Force using the system version of the macros.
>>
>> Signed-off-by: Andreas Färber <address@hidden>
>> ---
>> On 9.0-RELEASE I did not have this issue, so unsure if some version check
>> is needed or some more generic configure check?
>
> Looks plausible, but I have no bsd specific experience.
> I'd say if it works for both 9.0 and 10.0, let it go in as is.
This change builds fine for me on FreeBSD 9.
-Ed