[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 002/124] savevm: Remove all the unneded version_
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 002/124] savevm: Remove all the unneded version_minimum_id_old (usb) |
Date: |
Mon, 21 Apr 2014 09:30:56 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/21/2014 08:39 AM, Juan Quintela wrote:
s/unneded/unneeded/ in the subject
> After previous Peter patch, they are redundant. This way we don't asign them
s/asign/assign/
> except when needed. Once there, there were lots of case where the ".fields"
> indentation was wrong:
>
> .fields = (VMStateField []) {
> and
> .fields = (VMStateField []) {
>
> Change all the combinations to:
>
> .fields = (VMStateField[]){
>
> The biggest problem (appart of aesthetics) was that checkpatch complained
s/appart of/apart from/
> when we copy&pasted the code from one place to another.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 001/124] savevm: Ignore minimum_version_id_old if there is no load_state_old, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 004/124] savevm: Remove all the unneded version_minimum_id_old (arm), Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 002/124] savevm: Remove all the unneded version_minimum_id_old (usb), Juan Quintela, 2014/04/21
- Re: [Qemu-devel] [PATCH 002/124] savevm: Remove all the unneded version_minimum_id_old (usb),
Eric Blake <=
- [Qemu-devel] [PATCH 005/124] savevm: Remove all the unneded version_minimum_id_old (x86), Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 003/124] savevm: Remove all the unneded version_minimum_id_old (ppc), Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 006/124] savevm: Remove all the unneded version_minimum_id_old (rest), Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 007/124] vmstate: Return error in case of error, Juan Quintela, 2014/04/21