Re: [Qemu-devel] [PATCH for-2.1 v1 2/3] qdev: Implement named GPIOs

[Peter Crosthwaite]

On Fri, Apr 25, 2014 at 12:02 AM, Andreas Färber <address@hidden> wrote:
> Am 09.04.2014 01:45, schrieb Peter Crosthwaite:
>> Implement named GPIOs on the Device layer. Listifies the existing GPIOs
>> stuff using string keys. Legacy un-named GPIOs are preserved by using
>> a NULL name string - they are just a single matchable element in the
>> name list.
>>
>> Signed-off-by: Peter Crosthwaite <address@hidden>
>> ---
>>
>>  hw/core/qdev.c         | 82 
>> ++++++++++++++++++++++++++++++++++++++++++--------
>>  include/hw/qdev-core.h | 25 ++++++++++++---
>>  qdev-monitor.c         | 14 ++++++---
>>  qtest.c                | 15 ++++++---
>>  4 files changed, 110 insertions(+), 26 deletions(-)
>
> Please don't roll your own list implementation, use qemu/queue.h.
>

Fair enough. Will respin.

While we are here, what do you think of the idea of using this to get
rid of sysbus IRQs completely? Just make all existing sysbus IRQs back
onto a fixed-name named GPIO and remove the qemu_irq stuffs from the
state struct completely? (one step closer to sysbus dismantlement).

Regards,
Peter

> Regards,
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
>