Re: [Qemu-devel] [PULL v2 2/2] usb: mtp filesharing

[Gerd Hoffmann]

  Hi,

> > +    trace_usb_mtp_op_get_device_info(s->dev.addr);
> > +
> > +    usb_mtp_add_u16(d, 0x0100);
> 
> Sect. 5.1.1.1 says:
> 
>     "This identifies the PTP version this device can support in
>     hundredths.  For MTP devices implemented under this specification,
>     this shall contain the value 100 (representing 1.00)."
> 
> Is it an error in the spec (missing 0x) or should the value here really
> be 0x0100 instead of 0x0064?

It's probably /me not reading careful enough and assuming bcd version
encoding which is frequently used elsewhere in usb ...

Thanks for the careful review, as the patch got merged I'll go send out
a series of incremental fixes.

cheers,
  Gerd