Re: [Qemu-devel] [PATCH v25 30/31] cleanup QEMUOptionParameter

[Chun Yan Liu]

>>> On 4/25/2014 at 08:42 PM, in message
<address@hidden>, Stefan Hajnoczi
<address@hidden> wrote: 
> On Fri, Apr 11, 2014 at 01:54:26AM +0800, Chunyan Liu wrote: 
> > Now that all backend drivers are using QemuOpts, remove all 
> > QEMUOptionParameter related codes. 
> >  
> > Signed-off-by: Dong Xu Wang <address@hidden> 
> > Signed-off-by: Chunyan Liu <address@hidden> 
> > --- 
> >  block.c                   |  86 ++-------- 
> >  block/cow.c               |   4 +- 
> >  block/gluster.c           |   8 +- 
> >  block/iscsi.c             |   2 +- 
> >  block/nfs.c               |   2 +- 
> >  block/qcow.c              |   4 +- 
> >  block/qcow2.c             |   6 +- 
> >  block/qed.c               |   4 +- 
> >  block/raw-posix.c         |  10 +- 
> >  block/raw-win32.c         |   2 +- 
> >  block/raw_bsd.c           |   4 +- 
> >  block/rbd.c               |   2 +- 
> >  block/sheepdog.c          |   6 +- 
> >  block/ssh.c               |   2 +- 
> >  block/vdi.c               |   2 +- 
> >  block/vhdx.c              |   4 +- 
> >  block/vmdk.c              |   6 +- 
> >  block/vpc.c               |   2 +- 
> >  block/vvfat.c             |  12 +- 
> >  include/block/block.h     |   8 +- 
> >  include/block/block_int.h |  16 +- 
> >  include/qemu/option.h     |  48 +----- 
> >  qemu-img.c                |  19 +-- 
> >  util/qemu-option.c        | 426  
> +--------------------------------------------- 
> >  24 files changed, 68 insertions(+), 617 deletions(-) 
>  
> In block/gluster.c s/\<OPT_STRING/QEMU_OPT_STRING/g: 
>  
>   CC    block/gluster.o 
>   block/gluster.c:701:21: error: ‘OPT_STRING’ undeclared here (not in a  
> function) 
>                .type = OPT_STRING, 
>  
>  
Will update 14/31 block/gluster.c:
       .type = QEMU_OPT_STRING,