Re: [Qemu-devel] [PATCH 07/16] pci: add Error-propagating pci_add_capability2()

[Eric Blake]

On 04/29/2014 11:51 AM, Laszlo Ersek wrote:
> On 04/29/14 19:41, Eric Blake wrote:
>> On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
>>> ... and rebase pci_add_capability() to it.
>>>
>>> Signed-off-by: Laszlo Ersek <address@hidden>
>>> ---

>>> +int pci_add_capability2(PCIDevice *pdev, uint8_t cap_id,
>>> +                       uint8_t offset, uint8_t size,
>>> +                       Error **errp);
>>
>> Indentation is off; might be transient if you merge things back into one
>> pci_add_capability later in the series.  Modulo that,
>> Reviewed-by: Eric Blake <address@hidden>
>>
> 
> Hm, I'm afraid I missed to reindent the parameter list by one space for
> good, in both declaration and definition. Do you want me to respin
> because of that?

I'd wait for a maintainer to chime in on whether they are okay fixing it
as part of preparing the pull request, asking for a respin, or leaving
it as-is.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature