Re: [Qemu-devel] [PATCH 14/16] pci-assign: propagate errors from assign_device()

[Eric Blake]

On 04/10/2014 02:24 AM, Laszlo Ersek wrote:
> Also, change the return type to "void"; the function is static (with a
> sole caller) and the negative errno values are not distinguished from each
> other.
> 
> Signed-off-by: Laszlo Ersek <address@hidden>
> ---
>  hw/i386/kvm/pci-assign.c | 29 +++++++++++++++--------------
>  1 file changed, 15 insertions(+), 14 deletions(-)
> 

>      if (!kvm_check_extension(kvm_state, KVM_CAP_PCI_SEGMENT) &&
>          dev->host.domain) {
> -        error_report("Can't assign device inside non-zero PCI segment "
> -                     "as this KVM module doesn't support it.");
> -        return -ENODEV;
> +        error_setg(errp, "Can't assign device inside non-zero PCI segment "
> +                   "as this KVM module doesn't support it.");

We prefer avoiding trailing '.' in error messages; as long as you are
touching this, you could clean it up.  Not necessarily worth a respin on
its own; depends on what a maintainer will say.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature