Re: [Qemu-devel] [PATCH] vfio-pci: Quirk RTL8168 NIC

[Francois Romieu]

Alex Williamson <address@hidden> :
[...]
> device MSI will be blocked.  The Linux driver doesn't make use of this
> window, so apparently it's not required to make use of MSI-X.  This

It does not really use MSI-X (no RSS).

> quirk makes the device work with the Windows driver that does use this
> window for MSI-X, but I certainly cannot recommend this device for
> assignment (the Windows 7 driver also constantly pokes PCI config
> space).

Do you have some offsets for those ?

> diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
> index 9cf5b84..c3d2f7a 100644
> --- a/hw/misc/vfio.c
> +++ b/hw/misc/vfio.c
[...]
> + * "address latched" indicator.  Bits 12:15 is a mask field, which we're
> + * going to ignore because we don't really know what it means and the MSI-X
> + * area always seems to be accessed with a full mask.

s/seems to/should always/

Double word accesses requires the full mask. The MSIX area should be accessed
through double words.

-- 
Ueimor