[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/18] blockdev: Don't use qerror_report_err() in dr
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 01/18] blockdev: Don't use qerror_report_err() in drive_init() |
Date: |
Tue, 13 May 2014 18:02:35 +0200 |
qerror_report_err() is a transitional interface to help with
converting existing HMP commands to QMP. It should not be used
elsewhere.
drive_init() is not meant to be used by QMP commands. It uses both
qerror_report_err() and error_report(). Convert the former to the
latter.
Signed-off-by: Markus Armbruster <address@hidden>
---
blockdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 1a12e24..24b1c3b 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -691,7 +691,7 @@ DriveInfo *drive_init(QemuOpts *all_opts,
BlockInterfaceType block_default_type)
&error_abort);
qemu_opts_absorb_qdict(legacy_opts, bs_opts, &local_err);
if (local_err) {
- qerror_report_err(local_err);
+ error_report("%s", error_get_pretty(local_err));
error_free(local_err);
goto fail;
}
@@ -903,7 +903,7 @@ DriveInfo *drive_init(QemuOpts *all_opts,
BlockInterfaceType block_default_type)
dinfo = blockdev_init(filename, bs_opts, &local_err);
if (dinfo == NULL) {
if (local_err) {
- qerror_report_err(local_err);
+ error_report("%s", error_get_pretty(local_err));
error_free(local_err);
}
goto fail;
--
1.8.1.4
- [Qemu-devel] [PATCH 00/18] [PATCH 00/18] block: Purge qerror_report(), Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 03/18] qemu-nbd: Don't use qerror_report(), Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 02/18] blockdev: Don't use qerror_report() in do_drive_del(), Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 01/18] blockdev: Don't use qerror_report_err() in drive_init(),
Markus Armbruster <=
- [Qemu-devel] [PATCH 08/18] block/ssh: Propagate errors through connect_to_ssh(), Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 04/18] block/rbd: Propagate errors to open and create methods, Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 05/18] block/ssh: Drop superfluous libssh2_session_last_errno() calls, Markus Armbruster, 2014/05/13