Re: [Qemu-devel] [PATCH v1 18/22] target-arm: A64: Generalize update_spsel for the various ELs

[Richard Henderson]

On 05/05/2014 11:08 PM, Edgar E. Iglesias wrote:
> -    /* EL0 has no access rights to update SPSel, and this code
> -     * assumes we are updating SP for EL1 while running as EL1.
> -     */
> -    assert(arm_current_pl(env) == 1);
> +    /* EL0 has no access rights to update SPSel.  */
> +    assert(cur_el >= 1 && cur_el <= 3);

The old comment makes it clear that we're not supposed to get here when running
as EL0.  The new comment makes this look like a possible DoS attack.


r~