[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/3] qapi: fix coding style in parameters lis
From: |
Amos Kong |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/3] qapi: fix coding style in parameters list |
Date: |
Wed, 21 May 2014 10:08:24 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, May 12, 2014 at 08:57:30PM -0600, Eric Blake wrote:
> On 05/07/2014 07:14 PM, Amos Kong wrote:
> > The space before pointers is redundant.
> >
> > Signed-off-by: Amos Kong <address@hidden>
> > ---
> > scripts/qapi-visit.py | 20 ++++++++++----------
> > 1 file changed, 10 insertions(+), 10 deletions(-)
>
> <rant>
> Appears to be unchanged from v2. Missing the Reviewed-by I gave on v2
> for the code, and you were even reminded about that in v3. I suggested
> a better wording for the commit message in v2:
>
> A space after * when declaring a pointer type is redundant.
>
> but that still hasn't been done. It's frustrating when review comments
> are not addressed (even if you don't want to make a particular change,
> at least document why keeping things unchanged is preferable, rather
> than silently ignoring the review).
> </rant>
Sorry about the careless.
> That said, the change is still correct, so it still deserves:
>
> Reviewed-by: Eric Blake <address@hidden>
Thanks for your patience of the new review-by.
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
--
Amos.
pgpaObbabh8We.pgp
Description: PGP signature
- [Qemu-devel] [PATCH v4 0/3] qapi: fix coding style in generated code, Amos Kong, 2014/05/07
- [Qemu-devel] [PATCH v4 2/3] qapi: add const prefix to 'char *' insider c_type(), Amos Kong, 2014/05/07
- [Qemu-devel] [PATCH v4 3/3] qapi: Suppress unwanted space between type and identifier, Amos Kong, 2014/05/07
- [Qemu-devel] [PATCH v4 1/3] qapi: fix coding style in parameters list, Amos Kong, 2014/05/07
- Re: [Qemu-devel] [PATCH v4 0/3] qapi: fix coding style in generated code, Luiz Capitulino, 2014/05/15
- Re: [Qemu-devel] [PATCH v4 0/3] qapi: fix coding style in generated code, Luiz Capitulino, 2014/05/16