[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/14] block: Plug memory leak on brv_open_image
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH 04/14] block: Plug memory leak on brv_open_image() error path |
Date: |
Tue, 27 May 2014 12:26:12 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
The Monday 26 May 2014 à 19:37:05 (+0200), Markus Armbruster wrote :
> Introduced in commit da557a. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> block.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block.c b/block.c
> index 40c5e1a..1996f84 100644
> --- a/block.c
> +++ b/block.c
> @@ -1196,6 +1196,7 @@ int bdrv_open_image(BlockDriverState **pbs, const char
> *filename,
> bdref_key);
> ret = -EINVAL;
> }
> + QDECREF(image_options);
> goto done;
> }
>
> --
> 1.9.3
>
>
Reviewed-by: Benoit Canet <address@hidden>
- [Qemu-devel] [PATCH 00/14] block: Plug assorted memory leaks, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 02/14] block/vvfat: Plug memory leak in enable_write_target(), Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 04/14] block: Plug memory leak on brv_open_image() error path, Markus Armbruster, 2014/05/26
- Re: [Qemu-devel] [PATCH 04/14] block: Plug memory leak on brv_open_image() error path,
Benoît Canet <=
- [Qemu-devel] [PATCH 03/14] qcow2: Plug memory leak on qcow2_invalidate_cache() error paths, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency(), Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 06/14] qemu-io: Plug memory leak in open command, Markus Armbruster, 2014/05/26