[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/14] qemu-io: Plug memory leak in open command
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 06/14] qemu-io: Plug memory leak in open command |
Date: |
Tue, 27 May 2014 18:10:56 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Benoît Canet <address@hidden> writes:
> The Monday 26 May 2014 à 19:37:07 (+0200), Markus Armbruster wrote :
>> Introduced in commit b543c5c. Spotted by Coverity.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> qemu-io.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/qemu-io.c b/qemu-io.c
>> index ef3fef6..ffbad25 100644
>> --- a/qemu-io.c
>> +++ b/qemu-io.c
>> @@ -175,6 +175,7 @@ static int open_f(BlockDriverState *bs, int argc, char
>> **argv)
>> } else if (optind == argc) {
>> return openfile(NULL, flags, growable, opts);
>> } else {
>> + QDECREF(opts);
>> return qemuio_command_usage(&open_cmd);
>> }
>> }
>> --
>> 1.9.3
>>
>>
> There is still a potential leak in openfile() in if (qemuio_bs).
I said "plug memory leak in open command", not "plug all memory leaks in
open command" ;)
Back to serious: you're right, and I'll plug that one, too.
- Re: [Qemu-devel] [PATCH 02/14] block/vvfat: Plug memory leak in enable_write_target(), (continued)
- [Qemu-devel] [PATCH 04/14] block: Plug memory leak on brv_open_image() error path, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 03/14] qcow2: Plug memory leak on qcow2_invalidate_cache() error paths, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency(), Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 06/14] qemu-io: Plug memory leak in open command, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 13/14] block/sheepdog: Plug memory leak in sd_snapshot_create(), Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 12/14] block/vvfat: Plug memory leak in read_directory(), Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 14/14] qemu-img: Plug memory leak in convert command, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 10/14] block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR, Markus Armbruster, 2014/05/26