[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] e1000: allow command-line selection of c
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] e1000: allow command-line selection of card model |
|
Date: |
Wed, 28 May 2014 11:15:03 +0200 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, May 21, 2014 at 02:27:43PM -0400, Gabriel L. Somlo wrote:
> -#define TYPE_E1000 "e1000"
> +#define TYPE_E1000 "e1000-base"
Please rename to TYPE_E1000_BASE.
It's confusing to call it TYPE_E1000 but then actually have a different
type use the "e1000" string.
Besides that, I'm happy.
Stefan
- [Qemu-devel] [PATCH v2 0/3] e1000: allow model/device_id selection on command line, Gabriel L. Somlo, 2014/05/21
- [Qemu-devel] [PATCH v2 1/3] e1000: avoid relying on device id (and soon, QOM) on data path, Gabriel L. Somlo, 2014/05/21
- [Qemu-devel] [PATCH v2 3/3] tests: e1000: test additional device IDs, Gabriel L. Somlo, 2014/05/21
- Re: [Qemu-devel] [ping: PATCH v2 0/3] e1000: allow model/device_id selection on command line, Gabriel L. Somlo, 2014/05/27
- Re: [Qemu-devel] [PATCH v2 0/3] e1000: allow model/device_id selection on command line, Michael S. Tsirkin, 2014/05/27