Re: [Qemu-devel] [PATCH v2 06/11] block: make 'top' argument to block-commit optional

[Eric Blake]

On 05/27/2014 08:28 AM, Jeff Cody wrote:
> Now that active layer block-commit is supported, the 'top' argument
> no longer needs to be mandatory.
> 
> Change it to optional, with the default being the active layer in the
> device chain.
> 
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Benoit Canet <address@hidden>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
>  blockdev.c             |  3 ++-
>  qapi-schema.json       |  7 ++++---
>  qmp-commands.hx        |  5 +++--
>  tests/qemu-iotests/040 | 28 ++++++++++++++++++----------
>  4 files changed, 27 insertions(+), 16 deletions(-)

Hmm, the HMP counterpart of 'commit' is not very full-featured compared
to QMP. I think that's a stronger argument for rebasing this series to
not even bother with HMP.  Just focus on the QMP interface, and save HMP
changes for a future day (if ever) when someone needs it.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature