qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/2] vnc: Drop superfluous conditionals aroun


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v2 1/2] vnc: Drop superfluous conditionals around g_free()
Date: Tue, 10 Jun 2014 10:03:22 +0200

> >> +    *cred = NULL;
> >>  
> >>      *cred = g_malloc(strlen(certdir) + strlen(filename) + 2);
> >
> > Still a dead store
> 
> No deader than before my patch :)
> 
> Still, it's as good an opportunity to drop it as any.  Gerd, would you
> like a v3?

It's an improvement in any case, so I'm not going to reject it.
Nevertheless a v3 would be nice though.

cheers,
  Gerd






reply via email to

[Prev in Thread] Current Thread [Next in Thread]