qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RESEND] migration: catch unknown flags in ram_lo


From: Peter Lieven
Subject: Re: [Qemu-devel] [PATCH RESEND] migration: catch unknown flags in ram_load
Date: Tue, 10 Jun 2014 10:04:43 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 10.06.2014 09:31, Amit Shah wrote:
On (Tue) 03 Jun 2014 [18:27:15], Dr. David Alan Gilbert wrote:
* Peter Lieven (address@hidden) wrote:
if a saved vm has unknown flags in the memory data qemu
currently simply ignores this flag and continues which
yields in an unpredictable result.

this patch catches all unknown flags and
aborts the loading of the vm.
Yes, I think that's quite nice - the only thing I'd add which would help
a little is an error_report() in the case where you have invalid flags
to let you know that's the reason for the EINVAL.

(Having spent the day tracking down migration bugs...)
Peter, can you please add these before we pick the patch up?

On its way.

Peter



reply via email to

[Prev in Thread] Current Thread [Next in Thread]