[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/4] json-parser: drop superfluous assignment
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/4] json-parser: drop superfluous assignment for token variable |
Date: |
Tue, 10 Jun 2014 06:35:37 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 06/10/2014 03:20 AM, address@hidden wrote:
> From: Gonglei <address@hidden>
>
> Signed-off-by: ChenLiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> ---
> qobject/json-parser.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
> @@ -461,10 +459,8 @@ static QObject *parse_object(JSONParserContext *ctxt,
> va_list *ap)
> goto out;
> }
> }
> - token = NULL;
> } else {
> - token = parser_context_pop_token(ctxt);
> - token = NULL;
> + (void)parser_context_pop_token(ctxt);
Does the compiler warn if you drop the cast-to-void? I tend to think of
it as fluff that usually doesn't add anything.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v3 4/4] vga: Fix divide-by-zero in vga_update_text, arei.gonglei, 2014/06/10