Re: [Qemu-devel] [PATCH] char: fix avail_connections init in qemu_chr_open_eventfd()

[Paolo Bonzini]

Il 11/06/2014 15:39, David Marchand ha scritto:
> When trying to use a ivshmem server with qemu, ivshmem init code tries to
> create a CharDriverState object for each eventfd retrieved from the server.
> To create this object, a call to qemu_chr_open_eventfd() is done.
> Right after this, before adding a frontend, qemu_chr_fe_claim_no_fail() is
> called.
> qemu_chr_open_eventfd() does not set avail_connections to 1, so no frontend can
> be associated because qemu_chr_fe_claim_no_fail() makes qemu stop right away.
>
> This problem comes from 456d60692310e7ac25cf822cc1e98192ad636ece
> "qemu-char: Call fe_claim / fe_release when not using qdev chr properties".
>
> Fix this, by setting avail_connections to 1 in qemu_chr_open_eventfd().
>
> Signed-off-by: David Marchand <address@hidden>
> ---
>  qemu-char.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
>
> No change since initial patch: http://patchwork.ozlabs.org/patch/316785/
> I just rebased this patch on top of master branch and removed the [RFC] part.

CCing Gerd who lately has been taking care of qemu-char.c 
(address@hidden).

The patch has a small coding style problem; it's missing braces around 
the "if" statement.  Please send an updated version and include Gerd in 
the email.

Thanks,

Paolo