Re: [Qemu-devel] [PATCH v2] qemu-iotests: Disable Quorum testing in 041 when Quorum is not builtin

[Stefan Hajnoczi]

On Mon, Jun 30, 2014 at 04:25:47PM +0200, Benoît Canet wrote:
> The Monday 30 Jun 2014 à 16:09:57 (+0200), Stefan Hajnoczi wrote :
> > On Fri, Jun 27, 2014 at 10:17:16PM +0200, Benoît Canet wrote:
> > I think this patch can be boiled down to 2 lines:
> > 
> >  if __name__ == '__main__':
> > +    if 'quorum' not in iotests.qemu_img('--help'):
> > +        iotests.notrun('not built with quorum support')
> >      iotests.main(supported_fmts=['qcow2', 'qed'])
> > 
> > What do you think?
> 
> The detection part could work using qemu_img_pipe.

You're right, I used the wrong function.  We need the stdout.

> Are we sure that the test won't fail in strange ways like
> when using skipTest ?

Not sure what you mean.

> If so do you want me to respin this patch with your version ?

Yes, please.

pgpxsGYGGfKiL.pgp
Description: PGP signature