[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in r
From: |
Amit Shah |
Subject: |
Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load |
Date: |
Wed, 9 Jul 2014 16:26:20 +0530 |
On (Wed) 09 Jul 2014 [11:50:18], Peter Maydell wrote:
> On 9 July 2014 11:44, Amit Shah <address@hidden> wrote:
> > On (Wed) 09 Jul 2014 [11:28:27], Peter Maydell wrote:
> >> On 9 July 2014 05:25, Amit Shah <address@hidden> wrote:
> >> > Juan is away for a couple of weeks. This looks like a good fix to
> >> > pull in for 2.1, though. Peter, do you agree? Can you pick this up
> >> > if so?
> >>
> >> What's the bug it's fixing? I had a look at the commit message,
> >> but that suggests it's just tightening up sanity checking, not
> >> fixing an actual issue... Maybe you can clarify.
> >
> > Right, it improves correctness: after this patch, we ensure a rogue or
> > corrupt migration stream cannot cause problems on the dest.
>
> OK; we're treating those as bugs so yes, I think this is 2.1
> material. Has somebody other than the original author tested
> it? (That's a step that would usually be done by Juan as the
> maintainer.) If somebody can provide a Tested-by: I'm happy
> to apply it to master.
Not really sure if Juan did that as part of his 'thanks, applied'
workflow, but I'll run this through the autotest migration tests and
report back.
Amit
- Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load, Peter Lieven, 2014/07/09
- Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load, Amit Shah, 2014/07/09
- Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load, Peter Maydell, 2014/07/09
- Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load, Amit Shah, 2014/07/09
- Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load, Peter Maydell, 2014/07/09
- Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load,
Amit Shah <=
- Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load, Peter Maydell, 2014/07/09
- Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load, Peter Lieven, 2014/07/09
- Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load, Eric Blake, 2014/07/09
- Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load, Amit Shah, 2014/07/11