[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging |
Date: |
Fri, 18 Jul 2014 07:42:36 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/18/2014 04:56 AM, Dr. David Alan Gilbert wrote:
> * Sanidhya Kashyap (address@hidden) wrote:
>> Hi,
>>
>> The following patches introduce the support of the dirty bitmap logging and
>> dumping to a specified file. This patch addresses the previous issues raised
>> by David and Juan. Since, I have not received any comments on the runstates,
>> I'll keep them in the patch series.
>
> Hi Sanidhya,
> I've finally got around to reading through your patches. Some general
> thoughts first, and I'll put some more detail on the patches themselves:
>
> 1) Do you have some examples of output?
> Can you see hot areas in the kernel or something else?
>
> 2) 'frequency' is probably the wrong name for the parameter you have; since
> the parameter is actually the delay between epochs, where as frequency
> would imply the number of epochs/second.
Agreed, please s/frequency/period/ throughout.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v4 5/8] BitmapLog: cancel mechanism for an already running dump bitmap process, (continued)
- [Qemu-devel] [PATCH v4 6/8] BitmapLog: set the frequency of the dump bitmap process, Sanidhya Kashyap, 2014/07/17
- [Qemu-devel] [PATCH v4 7/8] BitmapLog: get the information about the parameters, Sanidhya Kashyap, 2014/07/17
- [Qemu-devel] [PATCH v4 8/8] BitmapLog: python script for extracting bitmap from a binary file, Sanidhya Kashyap, 2014/07/17
- Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging, Dr. David Alan Gilbert, 2014/07/18
- Re: [Qemu-devel] [PATCH v4 0/8] Obtain dirty bitmap via VM logging, Eric Blake, 2014/07/18