Re: [Qemu-devel] [PATCH 4/7] a trivial code change for more idiomatic writing style

[Dr. David Alan Gilbert]

* address@hidden (address@hidden) wrote:
> From: Gonglei <address@hidden>
> 
> Signed-off-by: Gonglei <address@hidden>
> ---
>  qdev-monitor.c      | 2 +-
>  qemu-char.c         | 2 +-
>  util/qemu-sockets.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/qdev-monitor.c b/qdev-monitor.c
> index f87f3d8..3e30d38 100644
> --- a/qdev-monitor.c
> +++ b/qdev-monitor.c
> @@ -694,7 +694,7 @@ void qmp_device_del(const char *id, Error **errp)
>      DeviceState *dev;
>  
>      dev = qdev_find_recursive(sysbus_get_default(), id);
> -    if (NULL == dev) {
> +    if (dev == NULL) {

I know people who write it as 'NULL == dev' on purpose,
because that will cause an error if you accidentally type a single =
where as 'dev = NULL'  will just cause confusion.

Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK