Re: [Qemu-devel] [PATCH] vhost_net: start/stop guest notifiers properly

[Jason Wang]

On 08/18/2014 09:20 PM, William Dauchy wrote:
> On Mon, Aug 18, 2014 at 11:51 AM, Jason Wang <address@hidden> wrote:
>>  err:
>> @@ -254,16 +254,16 @@ void vhost_net_stop(VirtIODevice *dev, NetClientState 
>> *ncs,
>>      VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(vbus);
>>      int i, r;
>>
>> +    for (i = 0; i < total_queues; i++) {
>> +        vhost_net_stop_one(tap_get_vhost_net(ncs[i].peer), dev);
>> +    }
>> +
>>      r = k->set_guest_notifiers(qbus->parent, total_queues * 2, false);
>>      if (r < 0) {
>>          fprintf(stderr, "vhost guest notifier cleanup failed: %d\n", r);
>>          fflush(stderr);
>>      }
>>      assert(r >= 0);
>> -
>> -    for (i = 0; i < total_queues; i++) {
>> -        vhost_net_stop_one(tap_get_vhost_net(ncs[i].peer), dev);
>> -    }
>>  }
> since
> ed8b4af Refactor virtio-net to use generic get_vhost_net
> get_vhost_net is used instead of tap_get_vhost_net
>
> Could you rebase your patch to facilitate tests or is it intentional?

Not intentional, my tree is out of date. I will rebase the patch.

Thanks for pointing this out.
>
> Thanks,