[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vhost_net: start/stop guest notifiers properly
|
From: |
Jason Wang |
|
Subject: |
Re: [Qemu-devel] [PATCH] vhost_net: start/stop guest notifiers properly |
|
Date: |
Tue, 19 Aug 2014 10:49:07 +0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
On 08/19/2014 03:53 AM, Michael S. Tsirkin wrote:
> On Mon, Aug 18, 2014 at 05:51:31PM +0800, Jason Wang wrote:
>> > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue
>> > support changed the order of stopping the device. Previously
>> > vhost_dev_stop would disable backend and only afterwards, unset guest
>> > notifiers. We now unset guest notifiers while vhost is still
>> > active. This can lose interrupts causing guest networking to fail.
>> >
>> > Additionally, remove the hdev->started assert in vhost.c since we may
>> > want to start the guest notifiers before vhost starts and stop the
>> > guest notifiers after vhost is stopped.
>> >
>> > In particular, this has been observed during migration.
>> >
>> > Reported-by: "Zhangjie (HZ)" <address@hidden>
>> > Signed-off-by: Michael S. Tsirkin <address@hidden>
>> > Signed-off-by: Jason Wang <address@hidden>
> This doesn't seem to apply to master.
> Can you rebase please?
Yes, will send a new version.