[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 00/23] linux-user updates
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL v2 00/23] linux-user updates |
Date: |
Tue, 19 Aug 2014 12:59:44 +0100 |
On 19 August 2014 09:32, <address@hidden> wrote:
> From: Riku Voipio <address@hidden>
>
> The same as previous series, except the patch "make binfmt flag O require P"
> has been dropped.
>
> The following changes since commit 142f4ac5d5e024670ef4725e8943702b027e4218:
>
> Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-2014-08-15'
> into staging (2014-08-15 18:44:48 +0100)
>
> are available in the git repository at:
>
> git://git.linaro.org/people/riku.voipio/qemu.git linux-user-for-upstream
>
> for you to fetch changes up to 8349027af60e861fcc401c928eb76f9f418815d7:
Hi. I'm afraid this doesn't build on my ARM board:
/root/qemu/linux-user/syscall.c: In function 'do_open_by_handle_at':
/root/qemu/linux-user/syscall.c:5475:16: error: 'p' may be used
uninitialized in this function [-Werror=uninitialized]
The compiler seems to be correct here -- we should
be passing 'fh' to unlock_user(), not 'p' (which seems
to be completely useless and should be deleted).
This function and name_to_handle_at() also both seem
to be missing the necessary guest-to-host byteswaps
on the fields in struct file_handle.
thanks
-- PMM
- [Qemu-devel] [PULL v2 13/23] linux-user: Make ipc syscall's third argument an abi_long, (continued)
- [Qemu-devel] [PULL v2 13/23] linux-user: Make ipc syscall's third argument an abi_long, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 17/23] linux-user: Detect fault in sched_rr_get_interval, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 15/23] linux-user: Detect Negative Message Sizes in msgsnd System Call, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 20/23] linux-user: clock_nanosleep errno Handling on PPC, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 23/23] linux-user: check return value of malloc(), riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 14/23] linux-user: Conditionally Pass Attribute Pointer to mq_open(), riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 18/23] linux-user: Move get_ppc64_abi, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 22/23] linux-user: writev Partial Writes, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 21/23] linux-user: Support target-to-host translation of mlockall argument, riku . voipio, 2014/08/19
- [Qemu-devel] [PULL v2 19/23] linux-user: Minimum Sig Handler Stack Size for PPC64 ELF V2, riku . voipio, 2014/08/19
- Re: [Qemu-devel] [PULL v2 00/23] linux-user updates,
Peter Maydell <=