Re: [Qemu-devel] [PATCH v5 00/15] TriCore architecture guest implementation

[Andreas Färber]

Hi,

Am 13.08.2014 14:07, schrieb Bastian Koppelmann:
>  arch_init.c                         |    2 +
>  configure                           |    5 +
>  cpu-exec.c                          |   11 +-
>  cpus.c                              |    6 +
>  default-configs/tricore-softmmu.mak |    3 +
>  hw/tricore/Makefile.objs            |    1 +
>  hw/tricore/tricore_testboard.c      |  129 ++++
>  include/elf.h                       |    2 +
>  include/hw/tricore/tricore.h        |   54 ++
>  include/sysemu/arch_init.h          |    1 +
>  target-tricore/Makefile.objs        |    1 +
>  target-tricore/cpu-qom.h            |   71 ++
>  target-tricore/cpu.c                |  191 +++++
>  target-tricore/cpu.h                |  400 ++++++++++
>  target-tricore/helper.c             |  144 ++++
>  target-tricore/helper.h             |   25 +
>  target-tricore/op_helper.c          |  392 ++++++++++
>  target-tricore/translate.c          | 1259 +++++++++++++++++++++++++++++++
>  target-tricore/tricore-defs.h       |   28 +
>  target-tricore/tricore-opcodes.h    | 1406 
> +++++++++++++++++++++++++++++++++++
>  20 files changed, 4130 insertions(+), 1 deletion(-)
>  create mode 100644 default-configs/tricore-softmmu.mak
>  create mode 100644 hw/tricore/Makefile.objs
>  create mode 100644 hw/tricore/tricore_testboard.c
>  create mode 100644 include/hw/tricore/tricore.h
>  create mode 100644 target-tricore/Makefile.objs
>  create mode 100644 target-tricore/cpu-qom.h
>  create mode 100644 target-tricore/cpu.c
>  create mode 100644 target-tricore/cpu.h
>  create mode 100644 target-tricore/helper.c
>  create mode 100644 target-tricore/helper.h
>  create mode 100644 target-tricore/op_helper.c
>  create mode 100644 target-tricore/translate.c
>  create mode 100644 target-tricore/tricore-defs.h
>  create mode 100644 target-tricore/tricore-opcodes.h

I still haven't really looked at the CPU QOM parts yet (and won't get to
that shortly, no blocker), in this diffstat I am missing a MAINTAINERS
entry that names and CCs someone (you?) to take care of all those new
target-tricore/, hw/tricore/ and hw/include/tricore/ files in the future.

Have you tested your new machine using "make check V=1"? Just wondering
whether qom-test passes. (Sorry if I already asked earlier.)

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg