[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] qapi/block-core: Add "new" qcow2 options
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] qapi/block-core: Add "new" qcow2 options |
Date: |
Wed, 20 Aug 2014 13:45:58 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 08/20/2014 01:38 PM, Max Reitz wrote:
>>> +# Structure of flags for each metadata structure. Setting a field to
>>> 'true'
>>> +# makes qemu guard that structure against unintended overwriting.
>>> The default
>>> +# value is chosen according to the template given.
>>> +#
>>> +# @template: Specifies a template mode which can be adjusted using
>>> the other
>>> +# flags, defaults to 'cached'
>>> +#
>> Might be worth mentioning the other fields by name, but that's minor.
>
> Well, there were so many and it would've just been "X: Prevent
> unintended writes to X".
Bike-shedding ahead: maybe avoid the duplication by listing things in a
list, such as:
# @template: #optional Specify the template that controls the defaults
for all other fields (defaults to 'cached')
# @main-header, @active-l1, @active-l2, ...: #optional Specify a
specific override of whether to prevent unintended writes to that data
section (defaults determined by @template)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 2/4] qapi: Allow enums in anonymous unions, (continued)