[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RESEND 1/2] rng-egd: Free old chr_name value bef
|
From: |
Amos Kong |
|
Subject: |
Re: [Qemu-devel] [PATCH RESEND 1/2] rng-egd: Free old chr_name value before setting new one |
|
Date: |
Mon, 25 Aug 2014 23:59:28 +0800 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Aug 07, 2014 at 12:18:47PM +0200, Paolo Bonzini wrote:
> Il 07/08/2014 04:24, Amos Kong ha scritto:
> > Eduardo, a similar patch had been applied.
> >
> > commit 5e490b6a504912225dff0e520e1c6af68295d238
> > Author: Amos Kong <address@hidden>
> > Date: Thu Nov 21 16:42:50 2013 +0800
> >
> > rng-egd: remove redundant free
> >
> > We didn't set default chr_name, the free is redundant.
> >
> > Signed-off-by: Amos Kong <address@hidden>
> > Message-id: address@hidden
> > Signed-off-by: Anthony Liguori <address@hidden>
> >
>
> What if you set chr_name twice?
In this case, g_free() is necessary.
So I'm fine with Eduardo's patch: [PATCH RESEND 1/2] rng-egd: Free old chr_name
value
> Paolo
--
Amos.