|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH v2 08/23] block: Eliminate BlockDriverState member device_name[] |
Date: | Tue, 16 Sep 2014 16:32:37 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 16/09/2014 16:08, Markus Armbruster ha scritto: >>> >> + if (bs->device_list.tqe_prev) { >>> >> QTAILQ_REMOVE(&bdrv_states, bs, device_list); >>> >> + bs->device_list.tqe_prev = NULL; >> > >> > I think a comments explaining the trick you are doing here would be worthy: >> > after all you are touching directly the inner parts of a linked list and >> > bypassing the list API. > Fair enough. Or just add tqe_prev = NULL to QTAILQ_REMOVE. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |