[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize |
Date: |
Fri, 19 Sep 2014 08:06:18 +0200 |
On Do, 2014-09-18 at 20:47 +0800, address@hidden wrote:
> From: Gonglei <address@hidden>
>
> DeviceClass->init is the old interface, let's convert usb
> devices to the new realize API. In this way, all the
> implementations now use error_setg instead of
> qerror_report/error_report for reporting error.
Looks good overall. One minor style nit, and there is the usb-serial
issue pointed out by paolo, I'd like to see them handled. I don't care
much whenever you do than with a v3 or 2-3 incremental patches to this
one.
cheers,
Gerd
- [Qemu-devel] [PATCH v2 14/19] dev-hid: convert init to realize, (continued)
- [Qemu-devel] [PATCH v2 14/19] dev-hid: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 16/19] usb-audio: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 19/19] usb-bus: remove "init" from USBDeviceClass struct, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 18/19] usb-mtp: convert init to realize, arei.gonglei, 2014/09/18
- [Qemu-devel] [PATCH v2 17/19] usb-redir: convert init to realize, arei.gonglei, 2014/09/18
- Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize, Paolo Bonzini, 2014/09/18
- Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize, Markus Armbruster, 2014/09/18
- Re: [Qemu-devel] [PATCH v2 00/19] usb: convert device init to realize,
Gerd Hoffmann <=