[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/30] test: usb: add port test to uhci unit tes
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 06/30] test: usb: add port test to uhci unit test |
Date: |
Wed, 24 Sep 2014 14:30:25 +0200 |
On Mi, 2014-09-24 at 11:47 +0000, Igor Mammedov wrote:
> along with it move common code fro ehci test to
> a separate file to avoid duplication.
Having the code mode as separate patch makes it easier to see the actual
port test added ...
> +static void test_port_1(void)
> +{
> + QPCIBus *pcibus;
> + struct qhc uhci;
> +
> + pcibus = qpci_init_pc();
> + g_assert(pcibus != NULL);
> + usb_pci_init_one(pcibus, &uhci, QPCI_DEVFN(0x1d, 0), 4);
> + uhci_port_test(&uhci, 0, UHCI_PORT_CCS);
> }
... here. Why test only one of the two ports btw?
cheers,
Gerd
- [Qemu-devel] [PATCH 29/30] qdev: drop legacy hotplug fields/methods, (continued)
- [Qemu-devel] [PATCH 29/30] qdev: drop legacy hotplug fields/methods, Igor Mammedov, 2014/09/24
- [Qemu-devel] [PATCH 03/30] test: virtio-rng: check if hot-plug/unplug works, Igor Mammedov, 2014/09/24
- [Qemu-devel] [PATCH 11/30] qdev: HotplugHandler: provide unplug callback, Igor Mammedov, 2014/09/24
- [Qemu-devel] [PATCH 05/30] test: virtio-blk: check if hot-plug/unplug works, Igor Mammedov, 2014/09/24
- [Qemu-devel] [PATCH 06/30] test: usb: add port test to uhci unit test, Igor Mammedov, 2014/09/24
- Re: [Qemu-devel] [PATCH 06/30] test: usb: add port test to uhci unit test,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 04/30] test: virtio-net: check if hot-plug/unplug works, Igor Mammedov, 2014/09/24
- Re: [Qemu-devel] [PATCH 00/30] complete conversion to hotplug-handler API, Cornelia Huck, 2014/09/24