[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 7/7] virtio-scsi: Handle TMF request cancella
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 7/7] virtio-scsi: Handle TMF request cancellation asynchronously |
|
Date: |
Thu, 25 Sep 2014 10:40:16 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 25/09/2014 04:01, Fam Zheng ha scritto:
>>> > > -static void virtio_scsi_do_tmf(VirtIOSCSI *s, VirtIOSCSIReq *req)
>>> > > +typedef struct {
>>> > > + VirtIOSCSIReq *tmf_req;
>>> > > + int remaining;
>>> > > +} VirtIOSCSICancelTracker;
>> >
>> > What about putting "remaining" directly in VirtIOSCSIReq?
> It's rarely used, so I preferred managing it here.
>
It complicates the code though. If you really feel like economizing
space, put it in a union with "QTAILQ_ENTRY(VirtIOSCSIReq) next;".
Paolo
- [Qemu-devel] [PATCH v2 2/7] scsi-generic: Handle canceled request in scsi_command_complete, (continued)
- [Qemu-devel] [PATCH v2 2/7] scsi-generic: Handle canceled request in scsi_command_complete, Fam Zheng, 2014/09/24
- [Qemu-devel] [PATCH v2 3/7] scsi-bus: Unify request unref in scsi_req_cancel, Fam Zheng, 2014/09/24
- [Qemu-devel] [PATCH v2 4/7] scsi: Drop SCSIReqOps.cancel_io, Fam Zheng, 2014/09/24
- [Qemu-devel] [PATCH v2 5/7] scsi: Introduce scsi_req_canceled, Fam Zheng, 2014/09/24
- [Qemu-devel] [PATCH v2 6/7] scsi: Introduce scsi_req_cancel_async, Fam Zheng, 2014/09/24
- [Qemu-devel] [PATCH v2 7/7] virtio-scsi: Handle TMF request cancellation asynchronously, Fam Zheng, 2014/09/24
- Re: [Qemu-devel] [PATCH v2 0/7] virtio-scsi: Asynchronous cancellation, Paolo Bonzini, 2014/09/24