[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 11/11] kvm/valgrind: don't mark memory as initialized
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 11/11] kvm/valgrind: don't mark memory as initialized |
Date: |
Fri, 26 Sep 2014 16:38:10 +0200 |
From: Christian Borntraeger <address@hidden>
since commit 7dda5dc82a77 ("migration: initialize RAM to zero") the
guest memory is defined zero. No need to call valgrind on guest memory.
This reverts commit 62fe83318d2f ("qemu: Use valgrind annotations to
mark kvm guest memory as defined") thus speeding up kvm start if
<includedir>/valgrind/valgrind.h is available.
Signed-off-by: Christian Borntraeger <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
configure | 3 +--
kvm-all.c | 7 -------
2 files changed, 1 insertion(+), 9 deletions(-)
diff --git a/configure b/configure
index 1a9daa5..f9c0926 100755
--- a/configure
+++ b/configure
@@ -3961,12 +3961,11 @@ else
fi
########################################
-# check if we have valgrind/valgrind.h and valgrind/memcheck.h
+# check if we have valgrind/valgrind.h
valgrind_h=no
cat > $TMPC << EOF
#include <valgrind/valgrind.h>
-#include <valgrind/memcheck.h>
int main(void) {
return 0;
}
diff --git a/kvm-all.c b/kvm-all.c
index 6c6586f..4afcd05 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -44,10 +44,6 @@
#include <sys/eventfd.h>
#endif
-#ifdef CONFIG_VALGRIND_H
-#include <valgrind/memcheck.h>
-#endif
-
/* KVM uses PAGE_SIZE in its definition of COALESCED_MMIO_MAX */
#define PAGE_SIZE TARGET_PAGE_SIZE
@@ -1959,9 +1955,6 @@ int kvm_has_intx_set_mask(void)
void kvm_setup_guest_memory(void *start, size_t size)
{
-#ifdef CONFIG_VALGRIND_H
- VALGRIND_MAKE_MEM_DEFINED(start, size);
-#endif
if (!kvm_has_sync_mmu()) {
int ret = qemu_madvise(start, size, QEMU_MADV_DONTFORK);
--
2.1.0
- [Qemu-devel] [PULL 01/11] pit: fix pit interrupt can't inject into vm after migration, (continued)
- [Qemu-devel] [PULL 01/11] pit: fix pit interrupt can't inject into vm after migration, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 02/11] Introduce cpu_clean_all_dirty, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 04/11] kvmclock: Ensure time in migration never goes backward, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 03/11] kvmclock: Ensure proper env->tsc value for kvmclock_current_nsec calculation, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 05/11] hw/dma/i8257: Silence phony error message, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 06/11] target-i386: update fp status fix, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 08/11] serial: check if backed by a physical serial port at realize time, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 07/11] serial: reset state at startup, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 10/11] po: fix conflict with %.mo rule in rules.mak, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 09/11] kvmvapic: fix migration when VM paused and when not running Windows, Paolo Bonzini, 2014/09/26
- [Qemu-devel] [PULL 11/11] kvm/valgrind: don't mark memory as initialized,
Paolo Bonzini <=
- Re: [Qemu-devel] [PULL 00/11] KVM (and more) patches for 2014-09-26, Peter Maydell, 2014/09/26