[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] util: Emancipate id_wellformed() from QemuOpts
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH] util: Emancipate id_wellformed() from QemuOpts |
|
Date: |
Thu, 02 Oct 2014 15:42:21 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Stefan Hajnoczi <address@hidden> writes:
> On Tue, Sep 30, 2014 at 01:59:30PM +0200, Markus Armbruster wrote:
>> +bool id_wellformed(const char *id)
>> +{
>> + int i;
>> +
>> + if (!qemu_isalpha(id[0])) {
>> + return 0;
>
> false would be a bit nicer since the other return cases use true/false.
Missed when I changed the value to bool. Would you be willing to fix
this up on commit? If not, I'll respin.