[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] util: Emancipate id_wellformed() from QemuOpts
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] util: Emancipate id_wellformed() from QemuOpts |
|
Date: |
Thu, 2 Oct 2014 15:11:14 +0100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Oct 02, 2014 at 03:42:21PM +0200, Markus Armbruster wrote:
> Stefan Hajnoczi <address@hidden> writes:
>
> > On Tue, Sep 30, 2014 at 01:59:30PM +0200, Markus Armbruster wrote:
> >> +bool id_wellformed(const char *id)
> >> +{
> >> + int i;
> >> +
> >> + if (!qemu_isalpha(id[0])) {
> >> + return 0;
> >
> > false would be a bit nicer since the other return cases use true/false.
>
> Missed when I changed the value to bool. Would you be willing to fix
> this up on commit? If not, I'll respin.
Yes, I'll fix it when merging tomorrow.
Stefan
pgpSksNJqQ9kC.pgp
Description: PGP signature