Re: [Qemu-devel] [PATCH] linux-user: Fix fault address truncation AArch64

[Richard Henderson]

On 10/23/2014 05:06 AM, Peter Maydell wrote:
> On 23 October 2014 12:55,  <address@hidden> wrote:
>> From: Riku Voipio <address@hidden>
>>
>> On AArch64 the si_addr field of siginfo_t is truncated to 32 bits
>> because the fault address passes through an uint32_t variable. This
>> is fixed by changing the variable to uint64_t.
>>
>> v2 by Riku - follow Peters suggestion and drop the addr variable
>> since its only used once in the Aarch64 loop.
>>
>> Reported-by: Amanieu d'Antras <address@hidden>
>> Signed-off-by: Riku Voipio <address@hidden>
> 
> Ah, I was just wondering this morning whether I ought
> to do a version of this patch, so you've saved me the effort :-)
> 
> Reviewed-by: Peter Maydell <address@hidden>
> 
> (You might want to put the notes about v2 below the '---'.)

If you do that, please just modify the entire patch description.
I.e. don't talk about the type of a variable that doesn't exist.


r~