Re: [Qemu-devel] [PATCH v4 16/47] Return path: Source handling of return path

[Paolo Bonzini]

On 10/23/2014 08:00 PM, Dr. David Alan Gilbert wrote:
>>> > > +static bool migration_already_active(MigrationState *ms)
>>> > > +{
>>> > > +    switch (ms->state) {
>>> > > +    case MIG_STATE_ACTIVE:
>>> > > +    case MIG_STATE_SETUP:
>>> > > +        return true;
>>> > > +
>>> > > +    default:
>>> > > +        return false;
>>> > > +
>>> > > +    }
>>> > > +}
>> > 
>> > Should CANCELLING also be considered active?  It is on the source->dest
>> > path.
> Hmm, possibly - but my intention here was just to round up all of the
> places that already checked for ACTIVE+SETUP so that I could add 
> POSTCOPY_ACTIVE;
> only one of those places also checked for CANCELLING, so I left it out.

Ok, I would need to check the callers...  There may be bugs waiting to
be fixed. :)  For now I guess it's ok as is.

Thanks for answering my comments!

Paolo