[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/5] libqos: Change use of pointers to uint64
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/5] libqos: Change use of pointers to uint64_t in virtio |
Date: |
Mon, 17 Nov 2014 16:25:50 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
Am 17.11.2014 um 16:19 schrieb Marc Marí:
> El Mon, 17 Nov 2014 15:16:21 +0000
> Stefan Hajnoczi <address@hidden> escribió:
>> On Sat, Nov 01, 2014 at 06:02:26PM +0100, Marc Marí wrote:
>>> Convert use of pointers in functions of virtio to uint64_t in order
>>> to make it platform-independent.
>>>
>>> Add casting from pointers (in PCI functions) to uint64_t and vice
>>> versa through uintptr_t.
>>>
>>> Signed-off-by: Marc Marí <address@hidden>
>>> ---
>>> tests/libqos/virtio-pci.c | 20 +++++++++++---------
>>> tests/libqos/virtio.c | 8 ++++----
>>> tests/libqos/virtio.h | 16 ++++++++--------
>>> tests/virtio-blk-test.c | 21 ++++++++++++++-------
>>> 4 files changed, 37 insertions(+), 28 deletions(-)
>>
>> This makes sense. To fully abolish pointers the PCI code also needs
>> to be converted. Do plan plan to do that?
>>
>> Stefan
>
> Not planned, but if asked, I may do it.
Pretty please. :) I was wondering the same thing when reading the patch.
Regards,
Andreas
--
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg
[Qemu-devel] [PATCH v2 4/5] libqos: Add malloc generic, Marc Marí, 2014/11/01
[Qemu-devel] [PATCH v2 2/5] tests: Prepare virtio-blk-test for multi-arch implementation, Marc Marí, 2014/11/01
[Qemu-devel] [PATCH v2 3/5] libqos: Remove PCI assumptions in constants of virtio driver, Marc Marí, 2014/11/01
[Qemu-devel] [PATCH v2 5/5] libqos: Add virtio MMIO support, Marc Marí, 2014/11/01