Re: [Qemu-devel] [PATCH 1/9] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled

[Michael S. Tsirkin]

On Mon, Dec 08, 2014 at 04:08:00PM +0000, Igor Mammedov wrote:
> ACPI parser in XP considers PNP0A06 devices of CPU and
> memory hotplug as duplicates. Adding unique _UID
> to CPU hotplug device fixes BSOD.
> 
> Signed-off-by: Igor Mammedov <address@hidden>

And let's add them for memory hotplug as well?
Also, if we do stable branch release, we probably
want to only do it for memory hotplug in a separate
patch, right?
This way users who don't enable memory hotplug
are unaffected, reduces risk slightly.

> ---
>  hw/i386/acpi-dsdt-cpu-hotplug.dsl | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl 
> b/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> index 34aab5a..268d870 100644
> --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> +++ b/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> @@ -94,6 +94,7 @@ Scope(\_SB) {
>  
>      Device(CPU_HOTPLUG_RESOURCE_DEVICE) {
>          Name(_HID, EisaId("PNP0A06"))
> +        Name(_UID, "CPU hotplug resources")
>  
>          Name(_CRS, ResourceTemplate() {
>              IO(Decode16, CPU_STATUS_BASE, CPU_STATUS_BASE, 0, CPU_STATUS_LEN)
> -- 
> 1.8.3.1