Re: [Qemu-devel] [PATCH 3/3] qdev'ify dp8393x

[Andreas Färber]

Hi Laurent,

Am 29.12.2014 um 01:39 schrieb Laurent Vivier:
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
>  hw/mips/mips_jazz.c      |   2 +-
>  hw/net/dp8393x.c         | 182 
> +++++++++++++++++++++++++++++++----------------
>  include/hw/net/dp8393x.h |   1 -
>  3 files changed, 121 insertions(+), 64 deletions(-)

Thanks for doing this cleanup! "QOM'ify" would be more correct
(subject). Patch looks good except for one nit: Can you distinguish
between instance_init and realize function rather than using the old
SysBusDeviceClass::init?

Also, can dp83932_init() be inlined in the call site, or is it used in
multiple places?

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)